netdev - Re: [PATCH net RESEND v2] ipv6: fix route selection if kernel is not compiled with CONFIG_IPV6_ROUTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130710.173633.631366598766526289.davem@davemloft.net>
Date:	Wed, 10 Jul 2013 17:36:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, petrus.lt@...il.com,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net RESEND v2] ipv6: fix route selection if kernel is
 not compiled with CONFIG_IPV6_ROUTER_PREF

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Wed, 10 Jul 2013 23:00:12 +0200

> I changed the return value of rt6_check_neigh to:
>    1 in case of the dst entry validated
>   -1 in case of we had no dst_entry and we need to do rr now
>   -2 in case a we had a dst_entry and it did not validate

Please, at the very least, create an enumeration for this set of
possible return values.

Although I don't like how that RR boolean is passed around by
reference, I can't suggest anything better so I won't require
you to get rid of that.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html