netdev - Re: [PATCH net v2] ipv6: only static routes qualify for equal cost multipathing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130711.114419.1045272869172136221.davem@davemloft.net>
Date:	Thu, 11 Jul 2013 11:44:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, nicolas.dichtel@...nd.com
Subject: Re: [PATCH net v2] ipv6: only static routes qualify for equal cost
 multipathing

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 11 Jul 2013 19:02:31 +0200

> +	for (rt = rt0; rt && !(rt->rt6i_flags & RTF_EXPIRES);
> +	     rt = (struct rt6_info *)rt->dst.from);
> +	return !(rt && (rt->rt6i_flags & RTF_EXPIRES));

Please make this logic clearer, something like:


	for (rt = rt0; rt; rt = (struct rt6_info *)rt->dst.from) {
		if (rt->rt6i_flags & RTF_EXPIRES)
			return false;
	}
	return true;

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html