netdev - Re: [PATCH 0/2] pkt_sched: sch_qfq: efficiency and codestyle improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130711.130132.1487792546552701732.davem@davemloft.net>
Date:	Thu, 11 Jul 2013 13:01:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	paolo.valente@...more.it
Cc:	jhs@...atatu.com, shemminger@...tta.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, fchecconi@...il.com,
	rizzo@....unipi.it, David.Laight@...LAB.COM
Subject: Re: [PATCH 0/2] pkt_sched: sch_qfq: efficiency and codestyle
 improvements

From: Paolo Valente <paolo.valente@...more.it>
Date: Wed, 10 Jul 2013 15:46:07 +0200

> Hi,
> this patchset tries to address the two issues raised by Dave in
> http://marc.info/?l=linux-kernel&m=136254542019113&w=2
> 
> The first of these issues has been also raised by
> David Laight:
> http://marc.info/?l=linux-kernel&m=136256446624557&w=2
> 
>> Although two topics for possibly resolving later:
>> 
>> 1) That 1ULL bit mask fix is quite expensive on 32-bit, it would
>>     probably be cheaper to test for that case using a helper function
>>     that nops out on 64-bit.  Although this is not so important.
>> 
> I have tried to find a simple solution, based on the properties of the mask.
> It is in the first patch.
> 
>> 2) That static inline forward declaration is ugly, better to remove
>>     the inline tag (let the compiler handle it) or move the function
>>     above all the call sites.
>> 
> Done by the second patch.

Looks good, thanks for doing this, both applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html