netdev - Re: [PATCH net] gre: Fix MTU sizing check for gretap tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130711.163001.2048627063903930724.davem@davemloft.net>
Date:	Thu, 11 Jul 2013 16:30:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	alexander.h.duyck@...el.com, netdev@...r.kernel.org,
	pshelar@...ira.com, jesse@...ira.com
Subject: Re: [PATCH net] gre: Fix MTU sizing check for gretap tunnels

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 11 Jul 2013 14:52:27 -0700

> On Thu, 2013-07-11 at 13:12 -0700, Alexander Duyck wrote:
>> This change fixes an MTU sizing issue seen with gretap tunnels when non-gso
>> packets are sent from the interface.
>> 
>> In my case I was able to reproduce the issue by simply sending a ping of
>> 1421 bytes with the gretap interface created on a device with a standard
>> 1500 mtu.
>> 
>> This fix is based on the fact that the tunnel mtu is already adjusted by
>> dev->hard_header_len so it would make sense that any packets being compared
>> against that mtu should also be adjusted by hard_header_len and the tunnel
>> header instead of just the tunnel header.
>> 
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
...
> Reported-by: Cong Wang <amwang@...hat.com>
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html