netdev - Re: [PATCH net] gre: Fix MTU sizing check for gretap tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130711.163049.2156289666282417262.davem@davemloft.net>
Date:	Thu, 11 Jul 2013 16:30:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	eric.dumazet@...il.com, alexander.h.duyck@...el.com,
	netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [PATCH net] gre: Fix MTU sizing check for gretap tunnels

From: Pravin Shelar <pshelar@...ira.com>
Date: Thu, 11 Jul 2013 16:19:17 -0700

> gre is been using dev->hard_header_len rather than
> rt_dev->hard_header_len for long time which does not look right.

I noticed this as well.

I would suggest implementing these calculations in small discrete
helper functions, with big comments.  Right now the code is hard
to understand even by experts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html