netdev - Re: [PATCH net v3] ipv6: only static routes qualify for equal cost multipathing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130712.163053.1149528998452445963.davem@redhat.com>
Date:	Fri, 12 Jul 2013 16:30:53 -0700 (PDT)
From:	David Miller <davem@...hat.com>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, nicolas.dichtel@...nd.com
Subject: Re: [PATCH net v3] ipv6: only static routes qualify for equal cost
 multipathing

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Fri, 12 Jul 2013 23:46:33 +0200

> Static routes in this case are non-expiring routes which did not get
> configured by autoconf or by icmpv6 redirects.
> 
> To make sure we actually get an ecmp route while searching for the first
> one in this fib6_node's leafs, also make sure it matches the ecmp route
> assumptions.
> 
> v2:
> a) Removed RTF_EXPIRE check in dst.from chain. The check of RTF_ADDRCONF
>    already ensures that this route, even if added again without
>    RTF_EXPIRES (in case of a RA announcement with infinite timeout),
>    does not cause the rt6i_nsiblings logic to go wrong if a later RA
>    updates the expiration time later.
> 
> v3:
> a) Allow RTF_EXPIRES routes to enter the ecmp route set. We have to do so,
>    because an pmtu event could update the RTF_EXPIRES flag and we would
>    not count this route, if another route joins this set. We now filter
>    only for RTF_GATEWAY|RTF_ADDRCONF|RTF_DYNAMIC, which are flags that
>    don't get changed after rt6_info construction.
> 
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html