netdev - Re: [PATCH net] ipv4: set transport header earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1373982986.10804.106.camel@edumazet-glaptop>
Date:	Tue, 16 Jul 2013 06:56:26 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Neal Cardwell <ncardwell@...gle.com>,
	netfilter-devel@...r.kernel.org, Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH net] ipv4: set transport header earlier

On Tue, 2013-07-16 at 17:24 +0400, Sergei Shtylyov wrote:
> > +	skb->transport_header = skb->network_header + iph->ihl*4;
> 
>     Spaces around * wouldn't hurt, to be consistent with the rest of the 
> statement and the Linux style in common.

I am well aware of this, I chose the convention used in this function
and file.

# grep ihl net/ipv4/ip_input.c
	opt->optlen = iph->ihl*4 - sizeof(struct iphdr);
	if (iph->ihl > 5 && ip_rcv_options(skb))
	if (iph->ihl < 5 || iph->version != 4)
	if (!pskb_may_pull(skb, iph->ihl*4))
	if (unlikely(ip_fast_csum((u8 *)iph, iph->ihl)))
	} else if (len < (iph->ihl*4))

Thanks




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html