netdev - Re: [PATCH net] ipv4: set transport header earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130716.130008.1606475609280013646.davem@davemloft.net>
Date:	Tue, 16 Jul 2013 13:00:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, ncardwell@...gle.com,
	netfilter-devel@...r.kernel.org, therbert@...gle.com
Subject: Re: [PATCH net] ipv4: set transport header earlier

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 15 Jul 2013 20:03:19 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit 45f00f99d6e ("ipv4: tcp: clean up tcp_v4_early_demux()") added a
> performance regression for non GRO traffic, basically disabling
> IP early demux.
> 
> IPv6 stack resets transport header in ip6_rcv() before calling
> IP early demux in ip6_rcv_finish(), while IPv4 does this only in
> ip_local_deliver_finish(), _after_ IP early demux.
> 
> GRO traffic happened to enable IP early demux because transport header
> is also set in inet_gro_receive()
> 
> Instead of reverting the faulty commit, we can make IPv4/IPv6 behave the
> same : transport_header should be set in ip_rcv() instead of
> ip_local_deliver_finish()
> 
> ip_local_deliver_finish() can also use skb_network_header_len() which is
> faster than ip_hdrlen()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html