netdev - Re: r8169: remove "PHY reset until link up" log spam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130723091722.1e791f0c@nehalam.linuxnetplumber.net>
Date:	Tue, 23 Jul 2013 09:17:22 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Peter Wu <lekensteyn@...il.com>
Cc:	Francois Romieu <romieu@...zoreil.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	nic_swsd@...ltek.com
Subject: Re: r8169: remove "PHY reset until link up" log spam

On Tue, 23 Jul 2013 18:07:15 +0200
Peter Wu <lekensteyn@...il.com> wrote:

> On Tuesday 23 July 2013 08:54:36 Stephen Hemminger wrote:
> > On Tue, 23 Jul 2013 11:55:57 +0200
> > 
> > Peter Wu <lekensteyn@...il.com> wrote:
> > > This message was added in commit a7154cb8 (June 2004) and is printed
> > > every ten seconds when no cable is connected.
> > > 
> > > Signed-off-by: Peter Wu <lekensteyn@...il.com>
> > > ---
> > > Using ethtool to silence *all* link warnings is still a manual
> > > operation, in my opinion not acceptable so let's remove this message.
> > > 
> > > The r8169 constantly resets the device when no link is connected,
> > > contrary the r8168 vendor driver which only resets the link when some
> > > PCI config fields have been modified. As the current reset logic in r8168
> > > seems to work for broken device (which I do not have have and therefore
> > > cannot test), I did not attempt to "clean this up".
> > > ---
> > > 
> > >  drivers/net/ethernet/realtek/r8169.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/net/ethernet/realtek/r8169.c
> > > b/drivers/net/ethernet/realtek/r8169.c index 880015c..63f04af 100644
> > > --- a/drivers/net/ethernet/realtek/r8169.c
> > > +++ b/drivers/net/ethernet/realtek/r8169.c
> > > @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp)
> > > 
> > >  	if (tp->link_ok(ioaddr))
> > >  	
> > >  		return;
> > > 
> > > -	netif_warn(tp, link, tp->dev, "PHY reset until link up\n");
> > > -
> > > 
> > >  	tp->phy_reset_enable(tp);
> > >  
> > >  out_mod_timer:
> > Why not implement netif msg flag to allow user to control this?
> 
> Which user wants to get log spam every ten seconds? I see no purpose except 
> when a developer asks a user to turn this on, or except if you are a 
> developer. This message was added almost ten years ago, Realtek must certainly 
> have improved their hardware not to be so crappy? 
> 
> See also <http://marc.info/?l=linux-netdev&m=137452974325684&w=2> where David 
> Miller wrote:
> > In every case where this issue has popped up, we have decided that
> > printing messages when the cable is simply unplugged is very
> > undesirable.
> 
> Regards,
> Peter

I meant the general link up/down message, not the silly polling message
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html