| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jul 2013 00:40:50 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Stephen Hemminger <stephen@...workplumber.org> CC: Helmut Grohne <h.grohne@...nusnetworks.de>, David Miller <davem@...emloft.net>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 1/3] tuntap: allow changing ethtool speed (v2) On Wed, 2013-07-24 at 16:11 -0700, Stephen Hemminger wrote: > The data reported by the ethtool interface for tun/tap devices is > artificial. The default speed is 10Mbit. Virtual interfaces are often > faster than this nowadays, so the observed bandwidth may exceed the > available bandwidth. This patch allows an administrator to change the > available bandwidth as reported by ethtool. > > Signed-off-by: Helmut Grohne <h.grohne@...nusnetworks.de> > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org> > > --- > v2 - allow setting duplex as well, fix patch formatting It's logically full duplex so this doesn't make sense to me. > ignore other settings in set [...] No, please never do that in ethtool_ops::set_settings. Setting unsupported values is an error. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists