netdev - Re: [PATCH] net: trans_rdma: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130724.164514.393667021861625699.davem@davemloft.net>
Date:	Wed, 24 Jul 2013 16:45:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pebolle@...cali.nl
Cc:	andi@...zian.org, ericvh@...il.com, rminnich@...dia.gov,
	lucho@...kov.net, v9fs-developer@...ts.sourceforge.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: trans_rdma: remove unused function

From: Paul Bolle <pebolle@...cali.nl>
Date: Thu, 25 Jul 2013 01:09:47 +0200

> On Wed, 2013-07-24 at 15:46 -0700, David Miller wrote:
>> From: Andi Shyti <andi@...zian.org>
>> > This patch gets rid of the following warning:
>> > 
>> > net/9p/trans_rdma.c:594:12: warning: ‘rdma_cancelled’ defined but not used [-Wunused-function]
>> >  static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
>> > 
>> > The rdma_cancelled function is not called anywhere in the kernel
>> > 
>> > Signed-off-by: Andi Shyti <andi@...zian.org>
>> 
>> Applied to net-next, thanks.
> 
> After this patch one might as well revert the rest of commit
> 80b45261a0b2 ("9P: Add cancelled() to the transport functions.") too. It
> seems the entire cancelled callback stuff is now pointless.
> 
> As I already asked in https://lkml.org/lkml/2013/7/15/87 : did that
> commit "forget to actually hook up rdma_cancelled() into
> p9_rdma_trans()?". It does look so to me.

If nobody responds to this in the next day or so, feel free to send me
a patch which rips it all out.

No response means they don't care, and neither, therefore, should we.

Thanks.