netdev - Re: [PATCH V2 net-next 2/2] pch_gbe: Add MinnowBoard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374711603.3436.246.camel@dvhart-mobl1.amr.corp.intel.com>
Date:	Wed, 24 Jul 2013 17:20:03 -0700
From:	Darren Hart <dvhart@...ux.intel.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, hpa@...or.com,
	peter.p.waskiewicz.jr@...el.com, andriy.shevchenko@...ux.intel.com,
	joe@...ches.com
Subject: Re: [PATCH V2 net-next 2/2] pch_gbe: Add MinnowBoard support

On Wed, 2013-07-24 at 17:00 -0700, David Miller wrote:
> From: Darren Hart <dvhart@...ux.intel.com>
> Date: Mon, 22 Jul 2013 14:41:59 -0700
> 
> > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
> > index da07907..be513a9 100644
> > --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
> > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
>  ...
> > @@ -277,4 +286,91 @@ void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
> >       pch_gbe_phy_read_reg_miic(hw, PHY_PHYSP_CONTROL, &mii_reg);
> >       mii_reg |= PHYSP_CTRL_ASSERT_CRS_TX;
> >       pch_gbe_phy_write_reg_miic(hw, PHY_PHYSP_CONTROL, mii_reg);
> > +
> > +     /* Setup a TX clock delay on certain platforms */
> > +     if (adapter->pdata && adapter->pdata->phy_tx_clk_delay)
> > +             pch_gbe_phy_tx_clk_delay(hw);
> > +}
> > +
> > +/* pch_gbe_phy_tx_clk_delay - Setup TX clock delay via the PHY
> > + * @hw:                  Pointer to the HW structure
> > + * Returns
> > + *   0:              Successful.
> > + *   -EINVAL:        Invalid argument.
> > + */
> > +int pch_gbe_phy_tx_clk_delay(struct pch_gbe_hw *hw)
>  ...
> > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h
> > index 03264dc..e3e4bc9 100644
> > --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h
> > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h
> > @@ -33,5 +33,7 @@ void pch_gbe_phy_power_up(struct pch_gbe_hw *hw);
> >  void pch_gbe_phy_power_down(struct pch_gbe_hw *hw);
> >  void pch_gbe_phy_set_rgmii(struct pch_gbe_hw *hw);
> >  void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw);
> > +int pch_gbe_phy_tx_clk_delay(struct pch_gbe_hw *hw);
> > +int pch_gbe_phy_disable_hibernate(struct pch_gbe_hw *hw);
> 
> 
> pch_gbe_phy_tx_clk_delay() is only invoked from pch_gbe_phy.c, where it is also
> implemented.
> 
> Therefore it should be marked static and the declaration removed from
> pch_gbe_phy.h

Ah, thanks. Leftover from a more complex driver_data with pointers to
these functions. I'll fix and resubmit this patch alone as V3.
Otherwise, no objections?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html