netdev - Re: [patch] net_sched: stack info leak in cbq_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375127072.2075.48.camel@joe-AO722>
Date:	Mon, 29 Jul 2013 12:44:32 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Jamal Hadi Salim <jhs@...atatu.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] net_sched: stack info leak in cbq_dump_wrr()

On Mon, 2013-07-29 at 22:36 +0300, Dan Carpenter wrote:
> opt.__reserved isn't cleared so we leak a byte of stack information.
[]
> diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
[]
> @@ -1469,6 +1469,7 @@ static int cbq_dump_wrr(struct sk_buff *skb, struct cbq_class *cl)
>  	opt.allot = cl->allot;
>  	opt.priority = cl->priority + 1;
>  	opt.cpriority = cl->cpriority + 1;
> +	opt.__reserved = 0;
>  	opt.weight = cl->weight;
>  	if (nla_put(skb, TCA_CBQ_WRROPT, sizeof(opt), &opt))
>  		goto nla_put_failure;

Alignment isn't guaranteed here so it'd
probably be better with a memset.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html