netdev - RE: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Jul 2013 09:59:20 +0000
From:	Duan Fugang-B38611 <B38611@...escale.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	Estevam Fabio-R49496 <r49496@...escale.com>,
	Li Frank-B20596 <B20596@...escale.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	Hector Palacios <hector.palacios@...i.com>,
	Tim Sander <tim.sander@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Florian Fainelli <florian@...nwrt.org>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: RE: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX_BUSY
 without link

On Tue, Jul 30, 2013 at 05:30 PM, Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:

>Don't test for having link and let hardware deal with this situation.
>
>Without this patch I see a machine running an -rt patched Linux being stuck in sch_direct_xmit when it looses link while there is still a packet to be sent. 
>In this case the fec_enet_start_xmit routine returned NETDEV_TX_BUSY which makes the network stack reschedule the packet and so sch_direct_xmit calls
>fec_enet_start_xmit again.
>I failed to reproduce a complete hang without -rt, but I think the problem exists there, too.
>
>Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@...gutronix.de>

Acked-and-tested-by: Fugang Duan  <B38611@...escale.com>