netdev - Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130730.160530.831845971567683172.davem@davemloft.net>
Date:	Tue, 30 Jul 2013 16:05:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	u.kleine-koenig@...gutronix.de
Cc:	netdev@...r.kernel.org, fabio.estevam@...escale.com,
	Frank.Li@...escale.com, shawn.guo@...aro.org,
	kernel@...gutronix.de, hector.palacios@...i.com,
	tim.sander@....com, rostedt@...dmis.org, tglx@...utronix.de,
	stephen@...workplumber.org, B38611@...escale.com,
	florian@...nwrt.org, bhutchings@...arflare.com
Subject: Re: [PATCH] net/fec: Don't let ndo_start_xmit return
 NETDEV_TX_BUSY without link

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Date: Tue, 30 Jul 2013 11:29:40 +0200

> Don't test for having link and let hardware deal with this situation.
> 
> Without this patch I see a machine running an -rt patched Linux being
> stuck in sch_direct_xmit when it looses link while there is still a
> packet to be sent. In this case the fec_enet_start_xmit routine returned
> NETDEV_TX_BUSY which makes the network stack reschedule the packet and
> so sch_direct_xmit calls fec_enet_start_xmit again.
> I failed to reproduce a complete hang without -rt, but I think the
> problem exists there, too.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html