netdev - Re: [PATCH V2 3/3] ethernet: Convert mac address uses of 6 to ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130801.141016.1475274289112004539.davem@davemloft.net>
Date:	Thu, 01 Aug 2013 14:10:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linux@....linux.org.uk
Cc:	joe@...ches.com, olof@...om.net, sammy@...my.net,
	grundler@...isc-linux.org, mcuos.com@...il.com,
	rajesh.borundia@...gic.com, netdev@...r.kernel.org,
	sony.chacko@...gic.com, linux-kernel@...r.kernel.org,
	manish.chopra@...gic.com, pcnet32@...ntier.com,
	ron.mercer@...gic.com, gallatin@...i.com, linux-driver@...gic.com,
	jitendra.kalsaria@...gic.com, linux-arm-kernel@...ts.infradead.org,
	shahed.shaikh@...gic.com
Subject: Re: [PATCH V2 3/3] ethernet: Convert mac address uses of 6 to
 ETH_ALEN

From: Russell King - ARM Linux <linux@....linux.org.uk>
Date: Thu, 1 Aug 2013 22:06:18 +0100

> On Thu, Aug 01, 2013 at 02:04:47PM -0700, Joe Perches wrote:
>> On Thu, 2013-08-01 at 21:58 +0100, Russell King - ARM Linux wrote:
>> > This seems rather obscure - I mean, it's not obvious to driver authors
>> > that should be the case.  Would it not be better to make this a little
>> > more obvious somehow?  Maybe __aligned(2) against mac_addr?  Or
>> > maybe have a debugging check for it?
>> 
>> That'd be for David Miller (cc'd).
>> 
>> I believe he's argued in the past that any alignment check
>> for mac addresses was unnecessary.
>> 
>> For all I know it really might not matter because pasemi
>> can successfully dereference a ushort against an odd char
>> pointer.
>> 
>> I just noticed it and thought it'd be better moved.
> 
> As can ARM too for years now - either in hardware or via fixup for
> kernel code.

But probably not a good idea if it's done in a fast path.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html