netdev - Re: [PATCH V2 3/3] ethernet: Convert mac address uses of 6 to ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMhf-2KE1B8_4CGJADCG=ceDFRrDbhTnA56kXYPWoKTScg@mail.gmail.com>
Date:	Thu, 1 Aug 2013 14:24:32 -0700
From:	Olof Johansson <olof@...om.net>
To:	David Miller <davem@...emloft.net>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Joe Perches <joe@...ches.com>, Sam Creasey <sammy@...my.net>,
	Grant Grundler <grundler@...isc-linux.org>,
	ZongShun Wan <mcuos.com@...il.com>,
	Rajesh Borundia <rajesh.borundia@...gic.com>,
	Network Development <netdev@...r.kernel.org>,
	Sony Chacko <sony.chacko@...gic.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Manish Chopra <manish.chopra@...gic.com>,
	Don Fry <pcnet32@...ntier.com>,
	Ron Mercer <ron.mercer@...gic.com>,
	Andrew Gallatin <gallatin@...i.com>, linux-driver@...gic.com,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Shahed Shaikh <shahed.shaikh@...gic.com>
Subject: Re: [PATCH V2 3/3] ethernet: Convert mac address uses of 6 to ETH_ALEN

On Thu, Aug 1, 2013 at 2:10 PM, David Miller <davem@...emloft.net> wrote:
> From: Russell King - ARM Linux <linux@....linux.org.uk>
> Date: Thu, 1 Aug 2013 22:06:18 +0100
>
>> On Thu, Aug 01, 2013 at 02:04:47PM -0700, Joe Perches wrote:
>>> On Thu, 2013-08-01 at 21:58 +0100, Russell King - ARM Linux wrote:
>>> > This seems rather obscure - I mean, it's not obvious to driver authors
>>> > that should be the case.  Would it not be better to make this a little
>>> > more obvious somehow?  Maybe __aligned(2) against mac_addr?  Or
>>> > maybe have a debugging check for it?
>>>
>>> That'd be for David Miller (cc'd).
>>>
>>> I believe he's argued in the past that any alignment check
>>> for mac addresses was unnecessary.
>>>
>>> For all I know it really might not matter because pasemi
>>> can successfully dereference a ushort against an odd char
>>> pointer.
>>>
>>> I just noticed it and thought it'd be better moved.
>>
>> As can ARM too for years now - either in hardware or via fixup for
>> kernel code.
>
> But probably not a good idea if it's done in a fast path.

This particular driver is for the PA Semi chips, and I very much doubt
that compatible hardware will ever show up anywhere else; they're
fairly dependent on the I/O architecture of the chip and Apple has not
brought those aspects forward in their ARM chips, as far as I know.

So, you might as well leave the code alone for now. It's not used on
fast path, and the system definitely handles unaligned accesses for
this -- it has for years already.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html