netdev - Re: [PATCH net v2 0/2] ipv6: prevent fib6_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130801.141854.195027071785270218.davem@davemloft.net>
Date:	Thu, 01 Aug 2013 14:18:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mkubecek@...e.cz
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net
Subject: Re: [PATCH net v2 0/2] ipv6: prevent fib6_run_gc() contention

From: Michal Kubecek <mkubecek@...e.cz>
Date: Thu,  1 Aug 2013 10:04:04 +0200 (CEST)

> On a high-traffic router with many processors and many IPv6 dst entries,
> soft lockup in fib6_run_gc() can occur when number of entries reaches
> gc_thresh. Prevent this by not waiting for the lock if garbage collector
> is already running as we would only run it again as soon as it finished.
> 
> v2: as suggested by Eric Dumazet, move update of ip6_rt_last_gc into
>     fib6_run_gc() so that it reflects every run of garbage collector
>     rather than only those via ip6_dst_gc()

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html