netdev - Re: [PATCH net-next v2] ipv6: fib6_rules should return exact return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130801.002646.2055621855734330896.davem@davemloft.net>
Date:	Thu, 01 Aug 2013 00:26:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, stefan.tomanek@...tarbyte.de,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next v2] ipv6: fib6_rules should return exact
 return value

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 1 Aug 2013 08:54:47 +0200

> With the addition of the suppress operation
> (7764a45a8f1fe74d4f7d301eaca2e558e7e2831a ("fib_rules: add .suppress
> operation") we rely on accurate error reporting of the fib_rules.actions.
> 
> fib6_rule_action always returned -EAGAIN in case we could not find a
> matching route and 0 if a rule was matched. This also included a match
> for blackhole or prohibited rule actions which could get suppressed by
> the new logic.
> 
> So adapt fib6_rule_action to always return the correct error code as
> its counterpart fib4_rule_action does. This also fixes a possiblity of
> nullptr-deref where we don't find a table, thus rt == NULL. Because
> the condition rt != ip6_null_entry still holdes it seems we could later
> get a nullptr bug on dereference rt->dst.
> 
> v2:
> a) Fixed a brain fart in the commit msg (the rule => a table, etc). No
>    changes to the patch.
> 
> Cc: Stefan Tomanek <stefan.tomanek@...tarbyte.de>
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html