netdev - Re: [net] net_sched: make dev_trans_start return vlan's real dev trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130803.115228.1509916868029010372.davem@davemloft.net>
Date:	Sat, 03 Aug 2013 11:52:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	nikolay@...hat.com, netdev@...r.kernel.org, fubar@...ibm.com,
	jhs@...atatu.com
Subject: Re: [net] net_sched: make dev_trans_start return vlan's real dev
 trans_start

From: Veaceslav Falico <vfalico@...hat.com>
Date: Sat, 3 Aug 2013 19:07:33 +0200

> On Sat, Aug 03, 2013 at 05:07:51PM +0200, nikolay@...hat.com wrote:
> ...snip...
>>+	while (is_vlan_dev(dev))
>>+		dev = vlan_dev_real_dev(dev);
> 
> While at it - I've checked a few users (mainly network drivers) of
> vlan_dev_real_dev(dev) and they all rely on that the return device
> would be the *real* device, but not another vlan.

Did you find any cases that want the device under the VLAN,
whether it is a non-vlan device or not?

> So maybe we should move this while loop to vlan_dev_real_dev()
> instead?

Perhaps.  As per above, we may also need the one-level demux
helper too, something like "vlan_dev_slave(dev)".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html