netdev - Re: [PATCH net] net: mlx5: fix sizeof usage in health_care's reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+2ELFBBPOnQdcLJVX4TVAsXvBUiGyupcRKahgATw1=-g@mail.gmail.com>
Date:	Sun, 4 Aug 2013 00:42:52 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Daniel Borkmann <dborkman@...hat.com>, Eli Cohen <eli@...lanox.com>
Cc:	ogerlitz@...lanox.com, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Eli Cohen <eli@....mellanox.co.il>
Subject: Re: [PATCH net] net: mlx5: fix sizeof usage in health_care's reg_handler

On Sat, Aug 3, 2013 at 1:43 AM, Daniel Borkmann <dborkman@...hat.com> wrote:

> On 08/03/2013 12:11 AM, David Miller wrote:
>>
>> From: Daniel Borkmann <dborkman@...hat.com>
>> Date: Fri,  2 Aug 2013 12:16:17 +0200
>>
>>> Therefore, I strongly assume sizeof(*health->health) is being meant
>>> to be passed as an argument. Interestingly, there are actually no
>>> in-tree users of mlx5_[un]register_health_report_handler(), but some
>>> debugging modules might want to know the correct size instead.
>>
>>
>> I want these hooks and infrastructure removed immediately.
>>
>> If there are no in-tree users there is no reason for them to
>> exist at all.
>
>
> Ok, I let Or handle that. Maybe he wants to add a user of it, instead.
>
> I also noticed that coverty scanner found a couple of other issues,
> e.g. outlen_write() in mlx5/core/cmd.c does a kzalloc() without
> doing sanity checks on the user-passed allocation size, e.g. it
> could even be a negative value passed to it.

Hi Daniel,

As listed in the kernel maintainers file, Eli Cohen (copied) is the
upstream maintainer for the mlx5 driver, please make sure to send/copy him
on patches/questions you have on mlx5. I will let Eli answer/handle your
findings/questions.

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html