netdev - Re: [PATCH 5/5] netfilter: add IPv6 SYNPROXY target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130807205718.GB21463@macbook.localnet>
Date:	Wed, 7 Aug 2013 22:57:18 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jesper Dangaard Brouer <jbrouer@...hat.com>
Cc:	pablo@...filter.org, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org, mph@....com, as@....com
Subject: Re: [PATCH 5/5] netfilter: add IPv6 SYNPROXY target

On Wed, Aug 07, 2013 at 10:34:40PM +0200, Jesper Dangaard Brouer wrote:
> 
> On Wed,  7 Aug 2013 19:42:51 +0200 Patrick McHardy <kaber@...sh.net> wrote:
> 
> > Add an IPv6 version of the SYNPROXY target. The main differences to
> > the IPv4 version is routing and IP header construction.
> > 
> > Signed-off-by: Patrick McHardy <kaber@...sh.net>
> 
> > +static int synproxy_tg6_check(const struct xt_tgchk_param *par)
> > +{
> > +	/// XXX PROTO match TCP
> 
> Ups, this looks like an comment to your self ;-)
> 
> > +	return nf_ct_l3proto_try_module_get(par->family);
> > +}

Oops right, I intended to add a check for proto TCP match in the rule
to make sure thoff is initialized by ip6tables.

I'll wait for more comments before sending an updated series.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html