netdev - Re: [PATCH] macvtap: fix two races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1376070067.20509.1.camel@edumazet-glaptop>
Date:	Fri, 09 Aug 2013 10:41:07 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	vyasevic@...hat.com
Cc:	Thomas Huth <thuth@...ux.vnet.ibm.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] macvtap: fix two races

On Fri, 2013-08-09 at 13:16 -0400, Vlad Yasevich wrote:

> I was looking at this a bit more and I think this call to 
> macvlan_count_rx() is double counting the packets.
> 
> In macvlan_handle_frame(), we call macvlan_count_rx() after we call
> vlan->receive().  For macvtap, receive() function is essentially 
> macvtap_forward() which just tacks the data onto the queue.
> 
> Then, the above code counts the data again as we pull it off the queue
> socket queue to give to the user.

Hmm, it seems a different issue, and probably needs a patch on its own.

When was this problem added ?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html