netdev - Re: [PATCH 2/2] net: asix: Move declaration of ax88172a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1376070636.20509.4.camel@edumazet-glaptop>
Date:	Fri, 09 Aug 2013 10:50:36 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Fabio Estevam <festevam@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"David S. Miller" <davem@...emloft.net>, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to
 shared header

On Fri, 2013-08-09 at 10:40 -0700, Stephen Hemminger wrote:
> On Fri, 9 Aug 2013 14:39:06 -0300
> Fabio Estevam <festevam@...il.com> wrote:
> 
> > On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown <broonie@...nel.org> wrote:
> > > From: Mark Brown <broonie@...aro.org>
> > >
> > > Ensure that the definition of ax88172a_info matches the declaration seen
> > > by users and silence sparse warnings about symbols without declarations
> > > in the global namespace by moving the declaration into the shared header
> > > asix.h.
> > >
> > > Signed-off-by: Mark Brown <broonie@...aro.org>
> > > ---
> > >  drivers/net/usb/asix.h         | 2 ++
> > >  drivers/net/usb/asix_devices.c | 2 --
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h
> > > index 346c032..bdaa12d 100644
> > > --- a/drivers/net/usb/asix.h
> > > +++ b/drivers/net/usb/asix.h
> > > @@ -178,6 +178,8 @@ struct asix_common_private {
> > >         struct asix_rx_fixup_info rx_fixup_info;
> > >  };
> > >
> > > +extern const struct driver_info ax88172a_info;
> > 
> > You could drop the 'extern' here.
> > 
> > All other function prototypes in this header file do not use 'extern'.
> 
> That is data, not function prototype, so yes extern is needed.


And this kind of contradictions show why extern declarations make sense
in include files, for text or/and data.

Some compiler folk decided 'extern' were not mandatory for code, but its
really adding confusion and endless discussions.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html