netdev - Re: [PATCH 2/2] net: asix: Move declaration of ax88172a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5Br3kug3OBi=cS+H57mUAKxhh2XdTuLBLyXt7JL=HYYuw@mail.gmail.com>
Date:	Fri, 9 Aug 2013 14:53:58 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Mark Brown <broonie@...nel.org>,
	"David S. Miller" <davem@...emloft.net>, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to
 shared header

On Fri, Aug 9, 2013 at 2:40 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:

>> > +extern const struct driver_info ax88172a_info;
>>
>> You could drop the 'extern' here.
>>
>> All other function prototypes in this header file do not use 'extern'.
>
> That is data, not function prototype, so yes extern is needed.

You are right, sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html