netdev - Re: [PATCH 2/2] ipv6: fix checkpatch errors in net/ipv6/addrconf.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5209D81D.1070702@huawei.com>
Date:	Tue, 13 Aug 2013 14:54:21 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	Joe Perches <joe@...ches.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] ipv6: fix checkpatch errors in net/ipv6/addrconf.c

On 2013/8/13 14:30, Joe Perches wrote:
> On Tue, 2013-08-13 at 14:15 +0800, Ding Tianhong wrote:
>> ERROR: Macros with complex values should be enclosed in parenthesis
>> +#define ADBG(x) printk x
> []
>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> []
>> @@ -99,7 +99,7 @@
> []
>> -#define ADBG(x) printk x
>> +#define ADBG(x) (printk x)
> 
> A better way to fix this would be
> to convert the uses of ADBG and remove
> the superfluous parentheses.
> 
> Something like the below but it might
> even better to remove the KERN_<LEVEL>s and
> just use pr_debug instead of ADBG...
> ---

thanks for your opinion. I think it's time to remove the tedious code and replace with pr_debug and pr_warning, I will send v2 to fix it.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html