netdev - RE: Query: Regarding 8211E Phy module support in drivers/net/phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A1A6EA40F8503D48BB002B42BD65974E0A111CDD@039-SN2MPN1-013.039d.mgd.msft.net>
Date:	Wed, 14 Aug 2013 20:18:03 +0000
From:	Sharma Bhupesh-B45370 <B45370@...escale.com>
To:	'Giuseppe CAVALLARO' <peppe.cavallaro@...com>
CC:	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>
Subject: RE: Query: Regarding 8211E Phy module support in drivers/net/phy


> -----Original Message-----
> From: Giuseppe CAVALLARO [mailto:peppe.cavallaro@...com]
> Sent: Wednesday, August 14, 2013 7:38 PM
> To: Sharma Bhupesh-B45370
> Cc: 'netdev@...r.kernel.org'
> Subject: Re: Query: Regarding 8211E Phy module support in drivers/net/phy
> 
> On 8/2/2013 8:50 PM, Sharma Bhupesh-B45370 wrote:
> > Hi Peppe,
> >
> > This regarding the patch prepared by you for adding RTL8211E support
> > in drivers/net/phy/realtek.c
> >
> > commit ef3d90491a15f0d5cf1ec39a38a45dac6968fb2a
> > Author: Giuseppe CAVALLARO <peppe.cavallaro@...com>
> > Date:   Wed Jan 23 00:30:03 2013 +0000
> >
> >      net: phy: realtek: add rtl8211e driver
> >
> >      This patch adds the minimal driver to manage the
> >      Realtek RTL8211E 10/100/1000 Transceivers.
> >
> > I see a macro specific to 8211E:
> > +#define        RTL8211E_INER_LINK_STAT 0x10
> >
> > I was having a look at the RTL8211E(G) datasheet and could see the
> > following bit positions for INER register (Address 0x12):
> >
> > [7:1] as Reserved
> > [0] as Jabber Interrupt
> >
> > If I am not wrong a value 0x10 written to the INER register tries to
> > set bit [4] which seems Reserved.
> 
> Hello Sharma
> you are right RTL8211E_INER_LINK_STAT should be 0x400 I will test it
> again (just to find the hw) and prepare/send a new patch.
>

Hi Peppe,

Glad to hear from you. Please test with the h/w and send the relevant patch
as I plan to send a patch supporting a new RTL phy module rebased on top of your patch.

Thanks for your help.
Regards,
Bhupesh

 
> Many thanks
> 
> peppe
> 
> >
> > Or am I missing something here.
> > Please let me know your views on the same.
> >
> > Thanks,
> > Bhupesh
> >
> >
> >
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html