netdev - Re: [PATCH] driver:net:stmmac: Disable DMA store and forward mode if platform data force_sf_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJxxZ0Pya_K-VJcAZ6yv00_F66uAd481vWgV-nWmPBWKOV760A@mail.gmail.com>
Date:	Fri, 16 Aug 2013 17:37:42 +0800
From:	Sonic Zhang <sonic.adi@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	peppe.cavallaro@...com, netdev <netdev@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	"Zhang, Sonic" <sonic.zhang@...log.com>
Subject: Re: [PATCH] driver:net:stmmac: Disable DMA store and forward mode if
 platform data force_sf_dma_mode is negative.

Hi David,

On Fri, Aug 16, 2013 at 5:20 AM, David Miller <davem@...emloft.net> wrote:
> From: Sonic Zhang <sonic.adi@...il.com>
> Date: Thu, 15 Aug 2013 15:37:36 +0800
>
>> @@ -1157,7 +1157,9 @@ static void free_dma_desc_resources(struct stmmac_priv *priv)
>>   */
>>  static void stmmac_dma_operation_mode(struct stmmac_priv *priv)
>>  {
>> -     if (likely(priv->plat->force_sf_dma_mode ||
>> +     if (priv->plat->force_sf_dma_mode < 0)
>> +             priv->hw->dma->dma_mode(priv->ioaddr, tc, tc);
>> +     else if (likely(priv->plat->force_sf_dma_mode > 0 ||
>>                  ((priv->plat->tx_coe) && (!priv->no_csum_insertion)))) {
>
> You need to properly re-indent the last line here so that
> the openning parenthesis lines up with the first column
> after the openning parenthesis on the "else if" line.

The last line is the original source code in master branch of the
Linus's kernel git tree. Do you mean I should fix the ident issue in
this patch as well?


Regards,

Sonic
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html