netdev - Re: [PATCH v2] r8169: fix invalid register dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130817211407.GA30676@electric-eye.fr.zoreil.com>
Date:	Sat, 17 Aug 2013 23:14:07 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Peter Wu <lekensteyn@...il.com>, netdev@...r.kernel.org,
	nic_swsd <nic_swsd@...ltek.com>
Subject: Re: [PATCH v2] r8169: fix invalid register dump

Ben Hutchings <bhutchings@...arflare.com> :
[...]
> I would be very wary of accessing registers with any width other than
> the usual (32 bits).

You are right. Most registers do not seem to care - some are 8 bits
wide - but the 8168c datasheet states that it's out of spec for the
descriptor ring address registers.

Peter, please use Ben's suggestion as is.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html