netdev - Re: [PATCH ipsec v2 3/3] xfrm: choose protocol family by skb protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130818160526.GA9414@order.stressinduktion.org>
Date:	Sun, 18 Aug 2013 18:05:26 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, steffen.klassert@...unet.com,
	edumazet@...gle.com
Subject: Re: [PATCH ipsec v2 3/3] xfrm: choose protocol family by skb protocol

On Sun, Aug 18, 2013 at 08:48:21AM -0700, Eric Dumazet wrote:
> On Sun, 2013-08-18 at 13:47 +0200, Hannes Frederic Sowa wrote:
> > We need to choose the protocol family by skb->protocol. Otherwise we
> > call the wrong xfrm{4,6}_local_error handler in case an ipv6 sockets is
> > used in ipv4 mode, in which case we should call down to xfrm4_local_error
> > (ip6 sockets are a superset of ip4 ones).
> > 
> > We are called before before ip_output functions, so skb->protocol is
> > not reset.
> > 
> > v2:
> > a) unchanged
> > 
> > Cc: Steffen Klassert <steffen.klassert@...unet.com>
> > Acked-by: Eric Dumazet <edumazet@...gle.com>
> > Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> > ---
> 
> Hi Hannes
> 
> For your next patches, please add the v1/v2/v3 stuff _after_ the ---
> separator as in :
> 
> Normal changelog (will be included in git history)
> 
> Signed-off-by: ....
> Cc: ...
> ---
> v2: Fix (you can omit this line if there was no change between v2 and
> v1)
>  diffstat
>  diff
> 
> 
> This is to have clean changelogs, with high S/N ratio ;)

Of course, I can do so.

Actually, I thought having the changelog in the commit msg is an extra
plus (even it is mostly inexpressive) because one knows there could be
more than one thread on the mailing list regarding the commit.

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html