netdev - Re: [PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5210FC71.3010600@ti.com>
Date:	Sun, 18 Aug 2013 22:25:13 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet

On 8/17/2013 12:16 AM, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/16/2013 06:11 PM, Lad, Prabhakar wrote:
> 
>> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> 
>> Add ethernet device tree node information and pinmux for mii to da850 by
>> providing interrupt details and local mac address.
> 
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
>> ---
>>   arch/arm/boot/dts/da850-evm.dts |    5 +++++
>>   arch/arm/boot/dts/da850.dtsi    |   30 ++++++++++++++++++++++++++++++
>>   2 files changed, 35 insertions(+)
> 
>> diff --git a/arch/arm/boot/dts/da850-evm.dts
>> b/arch/arm/boot/dts/da850-evm.dts
>> index 1f8cfdd..44f3fbc 100644
>> --- a/arch/arm/boot/dts/da850-evm.dts
>> +++ b/arch/arm/boot/dts/da850-evm.dts
>> @@ -96,6 +96,11 @@
>>               pinctrl-0 = <&mdio_pins>;
>>               bus_freq = <2200000>;
>>           };
>> +        ethernet: emac@...0000 {
> 
>    Why label the node in the board file too?

May be not required, but all other entries in da850-evm.dts have labels
too. Other .dts files like am335x-bone.dts use labels too (even though
they are never used in references). So I am inclined to let this be like
this and if needed have all the labels removed through a separate patch
- at least we remain consistent within the file that way.

Prabhakar,

Please mind the new e-mail address of the devicetree list.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html