netdev - Re: [PATCH 0/3] net: propagate dynamic needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130820142756.GB1593@minipsycho.brq.redhat.com>
Date:	Tue, 20 Aug 2013 16:27:56 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev <netdev@...r.kernel.org>, amwang@...hat.com,
	Stephen Hemminger <stephen@...workplumber.org>,
	kaber@...sh.net, David Miller <davem@...emloft.net>,
	vyasevic@...hat.com, Johannes Berg <johannes@...solutions.net>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH 0/3] net: propagate dynamic needed_headroom/tailroom
 changes

Tue, Aug 20, 2013 at 04:24:37PM CEST, f.fainelli@...il.com wrote:
>2013/8/20 Jiri Pirko <jiri@...nulli.us>:
>> Tue, Aug 20, 2013 at 02:45:49PM CEST, f.fainelli@...il.com wrote:
>>>Hi all,
>>>
>>>This patchset aims at allowing dynamically changing a given device
>>>needed_headroom/tailroom space and propagating such events to stacked
>>>devices such as bridges and vlans.
>>
>> You should also add support for other stacked devices, like bonding,
>> team, macvlan, ovs-datapath, etc.
>
>Ok, will take a look at these.
>
>>
>>>
>>>Unless callers use the new helpers (dev_set_headroom/dev_set_tailroom)
>>>there is no functional change introduced.
>>>
>>>I tested this with an out of tree Ethernet driver with both VLANs and
>>>bridges and the need for a 64-byte headroom to insert a transmit
>>>status descriptor in front of a SKB.
>>
>> Would be nice to add at least one driver which would use your new api.
>
>cxgb, niu, ps3_gelic_net and gianfar could probably directly benefit
>from this change.

Great, please add use of your new api to one of these and add that patch
to your set. Thanks!

>
>Thanks for your feedback!
>--
>Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html