netdev - Re: [PATCH 1/3] net: add a new NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377011818.13829.9.camel@jlt4.sipsolutions.net>
Date:	Tue, 20 Aug 2013 17:16:58 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, amwang@...hat.com, jiri@...nulli.us,
	stephen@...workplumber.org, kaber@...sh.net, davem@...emloft.net,
	vyasevic@...hat.com, eric.dumazet@...il.com
Subject: Re: [PATCH 1/3] net: add a new NETDEV_CHANGEROOM event type

On Tue, 2013-08-20 at 13:45 +0100, Florian Fainelli wrote:

>  /**
> + *	dev_set_headroom - Change device needed headroom
> + *	@dev: device
> + *	@new_headroom: new headroom size
> + *
> + * 	Change the network device headroom space.
> + */
> +int dev_set_headroom(struct net_device *dev, unsigned short new_headroom)

It seems that you need to invoke these under RTNL, might be worth
documenting that.

Also, maybe it would be worth doing it in one call? If you need to
change both, then you'd end up calling the notifier twice, which is less
efficient? I suppose you could make them 'int' arguments and reserve -1
for no changes, or just require both new values to be given (if doing
this at all.)

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html