netdev - Re: [PATCH (net.git) 1/2] stmmac: disable at run-time the EEE if not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130820.170416.2028716553359945223.davem@davemloft.net>
Date:	Tue, 20 Aug 2013 17:04:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	peppe.cavallaro@...com, netdev@...r.kernel.org
Subject: Re: [PATCH (net.git) 1/2] stmmac: disable at run-time the EEE if
 not supported

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Mon, 19 Aug 2013 22:44:24 +0400

>> @@ -2166,7 +2181,6 @@ static int stmmac_poll(struct napi_struct *napi,
>> int budget)
>>   static void stmmac_tx_timeout(struct net_device *dev)
>>   {
>>   	struct stmmac_priv *priv = netdev_priv(dev);
>> -
>>   	/* Clear Tx resources and restart transmitting again */
> 
>    Why? This seems unneeded change.

Agreed, not only was this code properly styled already, changing it
is totally unrelated to what this patch is supposed to be doing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html