[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20130820.170523.1476358382284760995.davem@davemloft.net>
Date: Tue, 20 Aug 2013 17:05:23 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: sergei.shtylyov@...entembedded.com
Cc: netdev@...r.kernel.org, lethal@...ux-sh.org,
linux-sh@...r.kernel.org
Subject: Re: [PATCH 1/2] SH7619: fix Ether support
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Sun, 18 Aug 2013 02:15:42 +0400
> The 'sh_eth' driver's probe will crash as the platform code is hopelessly behind
> the platform data -- it passes PHY ID instead of 'struct sh_eth_plat_data *'.
> Strangely, both commit d88a3ea6fa4c (SH7619 add ethernet controler support) that
> added the platform code and commit 71557a37adb5 ([netdrvr] sh_eth: Add SH7619
> support) were done in about the same time, yet the latter one added 'struct
> sh_eth_plat_data' and the platform code didn't ever get updated...
>
> Add the proper platform data and fix off-by-one memory resource end error, while
> at it...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists