netdev - Re: [PATCH 1/2] SH7619: fix Ether support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5214CCC6.8090206@cogentembedded.com>
Date:	Wed, 21 Aug 2013 18:20:54 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	netdev@...r.kernel.org
CC:	lethal@...ux-sh.org, linux-sh@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 1/2] SH7619: fix Ether support

Hello.

On 18-08-2013 2:15, Sergei Shtylyov wrote:

> The 'sh_eth' driver's probe will crash as the platform code is hopelessly behind
> the platform data -- it passes PHY ID instead of 'struct sh_eth_plat_data *'.
> Strangely, both commit d88a3ea6fa4c (SH7619 add ethernet controler support) that
> added the platform code and commit 71557a37adb5 ([netdrvr] sh_eth: Add  SH7619
> support)  were done  in about  the same time, yet the latter one added 'struct
> sh_eth_plat_data' and the platform code didn't ever get updated...
>
> Add the proper platform data and fix off-by-one memory resource end error, while
> at it...

> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Cc: stable@...r.kernel.org

> ---
>   arch/sh/kernel/cpu/sh2/setup-sh7619.c |   12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)

> Index: net/arch/sh/kernel/cpu/sh2/setup-sh7619.c
> ===================================================================
> --- net.orig/arch/sh/kernel/cpu/sh2/setup-sh7619.c
> +++ net/arch/sh/kernel/cpu/sh2/setup-sh7619.c
[...]
> @@ -110,10 +111,17 @@ static struct platform_device scif2_devi
>   	},
>   };
>
> +static struct sh_eth_plat_data eth_platform_data = {
> +	.phy		= 1,
> +	.edmac_endian	= EDMAC_LITTLE_ENDIAN,
> +	.register_type	= SH_ETH_REG_FAST_SH3_SH2,
> +	.phy_interace	= PHY_INTERFACE_MODE_MII,

    Grr, I forgot to compile test this patch as the kbuild test robot just 
told me... s/phy_interace/phy_interface/. I'll send a fix today.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html