lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5214D34B.8080701@cogentembedded.com>
Date:	Wed, 21 Aug 2013 18:48:43 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Sathya Perla <sathya.perla@...lex.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] be2net: fix disabling TX in be_close()

Hello.

On 21-08-2013 14:22, Sathya Perla wrote:

> commit fba875591 disabled TX in be_close() to protect be_xmit() from

    Please also specify that commit's summary line in parens.

> touching freed up queues in the AER recovery flow.
> But, TX must be disabled *before* cleaning up TX completions in the
> close() path, not after. This allows be_tx_compl_clean() to free up
> all TX-req skbs that were notified to the HW.

> Signed-off-by: Sathya Perla <sathya.perla@...lex.com>

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ