netdev - Re: [PATCH RESEND net-next 0/3] huawei_cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Aug 2013 22:26:24 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Enrico Mioso <mrkiko.rs@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND net-next 0/3] huawei_cdc_ncm introduction

Enrico Mioso <mrkiko.rs@...il.com> wrote:
>
>These patches are all related to the new huawei_cdc_ncm driver,
>supporting 
>devices that use the NCM protocol as a transport layer for other
>protocols. 
>this is the case of the Huawei E3131 3G modem.
>Thanks should go to bjorn and others who helped me with patience.
>
>Enrico Mioso (3):
>  net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use
>  net: huawei_cdc_ncm: Introduce the
>  net: cdc_ncm: remove non-standard NCM device IDs
>
> drivers/net/usb/Kconfig     |   11 +++++++++++
> drivers/net/usb/Makefile    |    1 +
> drivers/net/usb/cdc_ncm.c   |   17 ++++-------------
> include/linux/usb/cdc_ncm.h |    3 +++
> 4 files changed, 19 insertions(+), 13 deletions(-)

Just for the record: I strongly support this.

The Huawei devices were added to the cdc_ncm driver without any understanding of the embedded management protocol. We initially believed that the devices could be managed through an associated serial port. Now that Enrico has found that this isn't necessarily true, and that the embedded protocol is simply AT commands, it is clear that we should expose the embedded protocol to userspace. The absolutely best way to do that is by creating a new driver for these devices, reusing the parts of cdc-wdm and cdc-ncm which are common. Just like Enrico has done here.

Thanks for doing this!

Bjørn 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html