| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Aug 2013 11:26:10 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: David Miller <davem@...emloft.net> CC: <netdev@...r.kernel.org>, <linux-net-drivers@...arflare.com> Subject: Re: [PATCH RESEND net-next 06/16] sfc: Introduce and use MCDI_DECLARE_BUF macro On Thu, 2013-08-22 at 22:02 -0700, David Miller wrote: > From: Ben Hutchings <bhutchings@...arflare.com> > Date: Thu, 22 Aug 2013 20:26:49 +0100 > > > MCDI_DECLARE_BUF declares a variable as an MCDI buffer of the > > requested length, adding any necessary padding. > > > > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com> > > There really isn't a guarentee that a u8 array is going to > aligned appropriately to write dwords there using casts like > you do. Yes, but this has been wrong for years. > Since you're here macro'izing the declaration, take the time to fix it > to specify the necessary alignment as well. [...] My intent was to separate refactoring changes with no immediate effect (#6-9) from functional changes (#10-11), making them easier to review. The alignment gets fixed by #11. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists