netdev - Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y57s3cpa.fsf@nemi.mork.no>
Date:	Fri, 23 Aug 2013 12:48:17 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	netdev@...r.kernel.org, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Forest Bond <forest@...ttletooquiet.net>
Subject: Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

Dan Carpenter <dan.carpenter@...cle.com> writes:

> On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote:
>> Cc: Forest Bond <forest@...ttletooquiet.net>
>> Signed-off-by: Bjørn Mork <bjorn@...k.no>
>> ---
>
> The changlog is missing.

Yes, right.  Sorry about that.

>  Why does this patch help?

It ensures that addr_assign_type is set to the same value as the parent
device the dev_addr is copied from.  The initial reason was that I found
it strange to see NET_ADDR_PERM on a vlan device which had inherited a
random address from its parent.

But I haven't verified whether that the parent device actually can have
an addr_assign_type != NET_ADDR_PERM for every driver included. 

Bjørn

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html