netdev - Re: [PATCH net-next 2/2] sh_eth: Enable Rx descriptor word 0 shift for r8a7790

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130829000642.GB10207@verge.net.au>
Date:	Thu, 29 Aug 2013 09:06:42 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org, Magnus Damm <magnus.damm@...il.com>,
	Kouei Abe <kouei.abe.cp@...esas.com>
Subject: Re: [PATCH net-next 2/2] sh_eth: Enable Rx descriptor word 0 shift
 for r8a7790

On Wed, Aug 28, 2013 at 07:05:46PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/28/2013 04:43 AM, Simon Horman wrote:
> 
> >From: Kouei Abe <kouei.abe.cp@...esas.com>
> 
> >This corrects an oversight when r8a7790 support was added to sh_eth.
> 
>    No wonder it was overseen -- it's undocumented as of version 0.60
> of the manual.
> 
> >Signed-off-by: Kouei Abe <kouei.abe.cp@...esas.com>
> >Signed-off-by: Simon Horman <horms+renesas@...ge.net.au>
> >---
> >  drivers/net/ethernet/renesas/sh_eth.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> >diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> >index f386a8f..095ca8e 100644
> >--- a/drivers/net/ethernet/renesas/sh_eth.c
> >+++ b/drivers/net/ethernet/renesas/sh_eth.c
> >@@ -416,6 +416,7 @@ static struct sh_eth_cpu_data r8a7790_data = {
> >  	.tpauser	= 1,
> >  	.hw_swap	= 1,
> >  	.rmiimode	= 1,
> >+	.shift_rd0	= 1,
> 
>    I've seen the corresponding code in a Renesas BSP but wanted to
> double check before sending...

That is entirely reasonable.

I think that this email from Abe-san can count as a double-check.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html