netdev - Re: [PATCH net-next 1/2] sh_eth: Fix cache invalidation omission of receive buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130829.161553.755954777649764863.davem@davemloft.net>
Date:	Thu, 29 Aug 2013 16:15:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	horms+renesas@...ge.net.au
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	magnus.damm@...il.com, sergei.shtylyov@...entembedded.com,
	kouei.abe.cp@...esas.com
Subject: Re: [PATCH net-next 1/2] sh_eth: Fix cache invalidation omission
 of receive buffer

From: Simon Horman <horms+renesas@...ge.net.au>
Date: Wed, 28 Aug 2013 09:43:08 +0900

> From: Kouei Abe <kouei.abe.cp@...esas.com>
> 
> Signed-off-by: Kouei Abe <kouei.abe.cp@...esas.com>
> Signed-off-by: Simon Horman <horms+renesas@...ge.net.au>
> ---
>  drivers/net/ethernet/renesas/sh_eth.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index c357076..f386a8f 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1342,6 +1342,8 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status, int *quota)
>  			mdp->rx_skbuff[entry] = NULL;
>  			if (mdp->cd->rpadir)
>  				skb_reserve(skb, NET_IP_ALIGN);
> +			dma_sync_single_for_cpu(&ndev->dev, rxdesc->addr,
> +				mdp->rx_buf_sz,	DMA_FROM_DEVICE);

Please indent the second line of the dma sync call properly.

The arguments should start at the first column after the openning
parenthesis of the function call on the first line, using the
appropriate number of TAB then space characters (as needed).

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html