netdev - Re: [PATCH net-next v4 0/13] bonding: remove vlan special handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130829.162058.321510029835854765.davem@davemloft.net>
Date:	Thu, 29 Aug 2013 16:20:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, vyasevic@...hat.com, fubar@...ibm.com,
	andy@...yhouse.net, edumazet@...gle.com, jiri@...nulli.us,
	alexander.h.duyck@...el.com, amwang@...hat.com
Subject: Re: [PATCH net-next v4 0/13] bonding: remove vlan special handling

From: Veaceslav Falico <vfalico@...hat.com>
Date: Wed, 28 Aug 2013 23:25:03 +0200

> The aim of this patchset is to remove bondings' own vlan handling as much
> as possible and replace it with the netdev upper device functionality.
> 
> The upper device functionality is extended to include also lower devices
> and to have, for each device, a full view of every lower and upper device,
> but not only the first-level ones. This might permit in the future to
> avoid, for any grouping/teaming/upper/lower devices, to maintain its own
> lists of slaves/vlans/etc.
> 
> This is achieved by adding a helper function to upper dev list handling -
> netdev_upper_get_next_dev(dev, iter), which returns the next device after
> the list_head **iter, and sets *iter to the next list_head *. This patchset
> also adds netdev_for_each_upper_dev(dev, upper, iter), which iterates
> through the whole dev->upper_dev_list, setting upper to the net_device.
> The only special treatment of vlans remains in rlb code.
> 
> This patchset solves several issues with bonding, simplifies it overall,
> RCUify further and exports upper list functions for any other users which
> might also want to get rid of its own vlan_lists or slaves.
> 
> I'm testing it continuously currently, no issues found, will update on
> anything.

I like these changes a lot, nice work.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html