netdev - Re: [PATCH net-next v11 01/11] ipv6: move ip6_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1377925654.29366.1.camel@cr0>
Date:	Sat, 31 Aug 2013 13:07:34 +0800
From:	Cong Wang <amwang@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next v11 01/11] ipv6: move ip6_dst_hoplimit() into
 core kernel

On Sat, 2013-08-31 at 00:59 -0400, David Miller wrote:
> From: Cong Wang <amwang@...hat.com>
> Date: Sat, 31 Aug 2013 11:07:18 +0800
> 
> > @@ -75,3 +76,24 @@ int ip6_find_1stfragopt(struct sk_buff *skb, u8 **nexthdr)
> >  	return offset;
> >  }
> >  EXPORT_SYMBOL(ip6_find_1stfragopt);
> > +
> > +#if IS_ENABLED(CONFIG_IPV6)
> > +int ip6_dst_hoplimit(struct dst_entry *dst)
>  ...
> > +#endif
> > +EXPORT_SYMBOL(ip6_dst_hoplimit);
> 
> I don't think the export should be outside of the #if region.
> 
> Did you test the build with IPV6 disabled?

Yes, but it didn't show me any error.

Below is my 3 config's for IPV6:

% grep IPV6 .config_ipv6_*
.config_ipv6_m:CONFIG_IPV6=m
.config_ipv6_m:CONFIG_IPV6_PRIVACY=y
.config_ipv6_m:CONFIG_IPV6_ROUTER_PREF=y
.config_ipv6_m:CONFIG_IPV6_ROUTE_INFO=y
.config_ipv6_m:CONFIG_IPV6_OPTIMISTIC_DAD=y
.config_ipv6_m:CONFIG_IPV6_MIP6=m
.config_ipv6_m:CONFIG_IPV6_SIT=m
.config_ipv6_m:CONFIG_IPV6_SIT_6RD=y
.config_ipv6_m:CONFIG_IPV6_NDISC_NODETYPE=y
.config_ipv6_m:CONFIG_IPV6_TUNNEL=m
.config_ipv6_m:CONFIG_IPV6_GRE=m
.config_ipv6_m:CONFIG_IPV6_MULTIPLE_TABLES=y
.config_ipv6_m:CONFIG_IPV6_SUBTREES=y
.config_ipv6_m:CONFIG_IPV6_MROUTE=y
.config_ipv6_m:CONFIG_IPV6_MROUTE_MULTIPLE_TABLES=y
.config_ipv6_m:CONFIG_IPV6_PIMSM_V2=y
.config_ipv6_m:CONFIG_NF_DEFRAG_IPV6=m
.config_ipv6_m:CONFIG_NF_CONNTRACK_IPV6=m
.config_ipv6_m:CONFIG_IP6_NF_MATCH_IPV6HEADER=m
.config_ipv6_m:CONFIG_NF_NAT_IPV6=m
.config_ipv6_n:# CONFIG_IPV6 is not set
.config_ipv6_y:CONFIG_IPV6=y
.config_ipv6_y:CONFIG_IPV6_PRIVACY=y
.config_ipv6_y:CONFIG_IPV6_ROUTER_PREF=y
.config_ipv6_y:CONFIG_IPV6_ROUTE_INFO=y
.config_ipv6_y:CONFIG_IPV6_OPTIMISTIC_DAD=y
.config_ipv6_y:CONFIG_IPV6_MIP6=y
.config_ipv6_y:CONFIG_IPV6_SIT=y
.config_ipv6_y:CONFIG_IPV6_SIT_6RD=y
.config_ipv6_y:CONFIG_IPV6_NDISC_NODETYPE=y
.config_ipv6_y:CONFIG_IPV6_TUNNEL=y
.config_ipv6_y:CONFIG_IPV6_GRE=y
.config_ipv6_y:CONFIG_IPV6_MULTIPLE_TABLES=y
.config_ipv6_y:CONFIG_IPV6_SUBTREES=y
.config_ipv6_y:CONFIG_IPV6_MROUTE=y
.config_ipv6_y:CONFIG_IPV6_MROUTE_MULTIPLE_TABLES=y
.config_ipv6_y:CONFIG_IPV6_PIMSM_V2=y
.config_ipv6_y:# CONFIG_IP_VS_IPV6 is not set
.config_ipv6_y:# CONFIG_NF_DEFRAG_IPV6 is not set
.config_ipv6_y:# CONFIG_NF_CONNTRACK_IPV6 is not set


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html