netdev - Re: [PATCH net-next v11 01/11] ipv6: move ip6_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130831.015604.1949690105050158177.davem@davemloft.net>
Date:	Sat, 31 Aug 2013 01:56:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next v11 01/11] ipv6: move ip6_dst_hoplimit() into
 core kernel

From: Cong Wang <amwang@...hat.com>
Date: Sat, 31 Aug 2013 13:07:34 +0800

> On Sat, 2013-08-31 at 00:59 -0400, David Miller wrote:
>> From: Cong Wang <amwang@...hat.com>
>> Date: Sat, 31 Aug 2013 11:07:18 +0800
>> 
>> > @@ -75,3 +76,24 @@ int ip6_find_1stfragopt(struct sk_buff *skb, u8 **nexthdr)
>> >  	return offset;
>> >  }
>> >  EXPORT_SYMBOL(ip6_find_1stfragopt);
>> > +
>> > +#if IS_ENABLED(CONFIG_IPV6)
>> > +int ip6_dst_hoplimit(struct dst_entry *dst)
>>  ...
>> > +#endif
>> > +EXPORT_SYMBOL(ip6_dst_hoplimit);
>> 
>> I don't think the export should be outside of the #if region.
>> 
>> Did you test the build with IPV6 disabled?
> 
> Yes, but it didn't show me any error.

Weird, please correct this anyways.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html