netdev - RE: [PATCH] net: fec: fix the error to get the previous BD entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9848F2DB572E5649BA045B288BE08FBE0167E411@039-SN2MPN1-021.039d.mgd.msft.net>
Date:	Mon, 2 Sep 2013 02:23:00 +0000
From:	Duan Fugang-B38611 <B38611@...escale.com>
To:	Li Frank-B20596 <B20596@...escale.com>,
	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"l.stach@...gutronix.de" <l.stach@...gutronix.de>
Subject: RE: [PATCH] net: fec: fix the error to get the previous BD entry

From: Li Frank-B20596
Data: Monday, September 02, 2013 10:10 AM + 800

> To: Duan Fugang-B38611; David Miller
> Cc: netdev@...r.kernel.org; bhutchings@...arflare.com;
> l.stach@...gutronix.de
> Subject: RE: [PATCH] net: fec: fix the error to get the previous BD entry
> 
> >
> > Due to get tx & rx previous description use the same function
> > fec_enet_get_prevdesc(). If put the logic into
> > fec_enet_get_prevdesc(), I think it is better to split the function to
> > fec_enet_get_tx_prevdesc(),fec_enet_get_rx_prevdesc().
> >
> > If you agree it, I will submit one patch to do it.
> 
> It doesn't looks good to split to two functions.
> Can we use if (p == fep->tx_base || p == fep->rx_base) to check if get
> first entry of queue?

Yes, this check can get the first entry of queue, but the ring size is different for rx and tx ring.
In current driver, there have no tx/rx ring size variable define in struct fec_enet_private.

And, if change fec_enet_get_prevdesc(), the fec_enet_get_nextdesc() may need to do related logic change for nicety code.
 
> Best regards
> Frank Li

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html