netdev - Re: [RFC PATCH 4/4] ARM: dts: am33xx: adopt to cpsw-phy-sel driver to configure phy mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522F16C4.5030600@cogentembedded.com>
Date:	Tue, 10 Sep 2013 16:55:32 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Mugunthan V N <mugunthanvnm@...com>
CC:	netdev@...r.kernel.org, zonque@...il.com, davem@...emloft.net,
	bcousson@...libre.com, tony@...mide.com,
	devicetree@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [RFC PATCH 4/4] ARM: dts: am33xx: adopt to cpsw-phy-sel driver
 to configure phy mode

Hello.

On 09-09-2013 10:42, Mugunthan V N wrote:

>>> Add DT entries for the phy mode selection in AM33xx SoC using
>>> cpsw-phy-sel
>>> driver.

>>> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>
>>> ---
>>>    arch/arm/boot/dts/am33xx.dtsi | 6 ++++++
>>>    1 file changed, 6 insertions(+)

>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi
>>> b/arch/arm/boot/dts/am33xx.dtsi
>>> index f9c5da9..4359672 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -594,6 +594,12 @@
>>>                    /* Filled in by U-Boot */
>>>                    mac-address = [ 00 00 00 00 00 00 ];
>>>                };
>>> +
>>> +            phy_sel: cpsw_phy_sel@...10650 {

>>     Dashes are preferred to uderscores in the device tree names.

> I tried with dashes but i get the below error.

> $ make CROSS_COMPILE=arm-linux-gnueabihf- ARCH=arm dtbs
>    DTC     arch/arm/boot/dts/am335x-evm.dtb
> Error: arch/arm/boot/dts/am33xx.dtsi:598.11-12 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1
> make: *** [dtbs] Error 2

    Hm, perhaps the dashes can't be used in the labels but I was talking of 
the names. Dashes in the node names should be definitely valid.

> Regards
> Mugunthan V N

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html