netdev - Re: [PATCH v2 net-next 08/27] bonding: remove bond_for_each_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <l0oiea$jo6$2@ger.gmane.org>
Date:	Wed, 11 Sep 2013 01:53:14 +0000 (UTC)
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 08/27] bonding: remove
 bond_for_each_slave_reverse()

On Tue, 10 Sep 2013 at 20:57 GMT, Veaceslav Falico <vfalico@...hat.com> wrote:
> We only use it in rollback scenarios and can easily use the standart
> bond_for_each_dev() instead.
>

What you remove actually is bond_for_each_slave_continue_reverse()...
$subject needs to be fixed.


> diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
> index c3dcc6b..46f6b40 100644
> --- a/drivers/net/bonding/bond_alb.c
> +++ b/drivers/net/bonding/bond_alb.c
> @@ -1246,9 +1246,9 @@ static int alb_handle_addr_collision_on_attach(struct bonding *bond, struct slav
>   */
>  static int alb_set_mac_address(struct bonding *bond, void *addr)
>  {
> -	char tmp_addr[ETH_ALEN];
> -	struct slave *slave;
> +	struct slave *slave, *rollback_slave;
>  	struct sockaddr sa;
> +	char tmp_addr[ETH_ALEN];

Why are you moving tmp_addr[]?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html