netdev - Re: [PATCH v2 net-next 07/27] net: add for_each iterators through neighbour lower link's private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE3RKNmGd0npZ0gXUf=hx5C0DPOWutXJnAy-HoJBqRjFFkTjLw@mail.gmail.com>
Date:	Wed, 11 Sep 2013 07:37:59 +0200
From:	Veaceslav Falico <darkmag@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 07/27] net: add for_each iterators through
 neighbour lower link's private

On Wed, Sep 11, 2013 at 3:46 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Tue, 10 Sep 2013 at 20:57 GMT, Veaceslav Falico <vfalico@...hat.com> wrote:
>> +void *netdev_lower_get_next_private_rcu(struct net_device *dev,
>> +                                     struct list_head **iter)
>> +{
>> +     struct netdev_adjacent *lower;
>> +
>> +     WARN_ON_ONCE(!rcu_read_lock_held());
>> +
>
> Since this function has _rcu suffix, this warning is not useful at all.

I've been using it to catch offenders, just in case, like BUG_ON.

I can easily remove it, if needed, there are *tons* of cleanups
that can be made for this patchset, tbh, I've just left it the way it
is to be able to catch bug/review easier :).

p.s. Please, use reply-all when replying...

-- 
Best regards,
Veaceslav Falico
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html