netdev - Re: [PATCH 22/52] net: e100: remove unnecessary pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1378888791.2026.2.camel@jtkirshe-mobl>
Date:	Wed, 11 Sep 2013 01:39:51 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org,
	'Aaron Brown' <aaron.f.brown@...el.com>
Subject: Re: [PATCH 22/52] net: e100: remove unnecessary pci_set_drvdata()

On Wed, 2013-09-11 at 16:45 +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/net/ethernet/intel/e100.c |    2 --
>  1 file changed, 2 deletions(-)

While I do not find anything wrong with this patch, I personally like
good housekeeping so I would like to keep the code as is.  Is there a
reason for this patch?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)